linux-kernel - Re: [PATCH v2] kprobes: convert tests to kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yt9d8rzlgnvh.fsf@linux.ibm.com>
Date:   Sat, 25 Sep 2021 08:39:30 +0200
From:   Sven Schnelle <svens@...ux.ibm.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     kernel test robot <lkp@...el.com>,
        "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kprobes: convert tests to kunit

Hi Masami,

Masami Hiramatsu <mhiramat@...nel.org> writes:

> On Fri, 24 Sep 2021 20:19:20 +0200
> Sven Schnelle <svens@...ux.ibm.com> wrote:
>
>> kernel test robot <lkp@...el.com> writes:
>> 
>> > Hi Sven,
>> >
>> > Thank you for the patch! Yet something to improve:
>> >
>> [..]
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `entry_handler':
>> >>> test_kprobes.c:(.text+0x150): undefined reference to `kunit_unary_assert_format'
>> >>> ia64-linux-ld: test_kprobes.c:(.text+0x212): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `return_handler2':
>> >>> test_kprobes.c:(.text+0x2f0): undefined reference to `kunit_binary_assert_format'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x452): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x522): undefined reference to `kunit_do_assertion'
>> 
>> I missed that kunit can be built as module. I'll fix it an send a v3.
>
> Does this mean we can not use KUnit for the feature which is not exposed to module?

I changed the test_kprobes so that it can be build as a module now. (i
guess you already noticed that when looking at the v3 patch).