linux-kernel - Re: [PATCH v4 10/13] blk-mq: Add blk_mq_alloc_map_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YU/UPeIm3a1KjRHk@T590>
Date:   Sun, 26 Sep 2021 10:00:29 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     John Garry <john.garry@...wei.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        hare@...e.de
Subject: Re: [PATCH v4 10/13] blk-mq: Add blk_mq_alloc_map_and_rqs()

On Fri, Sep 24, 2021 at 04:28:27PM +0800, John Garry wrote:
> Add a function to combine allocating tags and the associated requests,
> and factor out common patterns to use this new function.
> 
> Some function only call blk_mq_alloc_map_and_rqs() now, but more
> functionality will be added later.
> 
> Also make blk_mq_alloc_rq_map() and blk_mq_alloc_rqs() static since they
> are only used in blk-mq.c, and finally rename some functions for
> conciseness and consistency with other function names:
> - __blk_mq_alloc_map_and_{request -> rqs}()
> - blk_mq_alloc_{map_and_requests -> set_map_and_rqs}()
> 
> Suggested-by: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> Reviewed-by: Hannes Reinecke <hare@...e.de>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

-- 
Ming