linux-kernel - Re: [PATCH] Remove uneccessary parantheas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4951952.txS7XvjiL2@localhost.localdomain>
Date:   Sun, 26 Sep 2021 10:13:46 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Estner <michaelestner@....de>
Cc:     michaelestner@....de, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove uneccessary parantheas

On Saturday, September 25, 2021 9:20:15 PM CEST Michael Estner wrote:
> Fix to be conform with the checkpatch style requirements

Greg K-H's "friendly patch bot" has already been triggered and sent you a 
message. Usually, according to Greg's style :), this is all you get and then 
you are left alone to figure out what you did wrong and eventually submit a 
new version.

However, as this is your very first patch, I would like to give you some 
additional information that may help you.

1) Where is the name of the driver your fixing? You must place it in the 
subject and its position and formatting must comply with this subsystem 
rules. Please, read other patches for staging among those that have already 
been accepted.

2) What language are you using in the subject? "Remove uneccessary 
parantheas" has no meaning in English. Typos can happen, but you have not 
made any typos: your "Subject line" is a completely incomprehensible sequence 
of characters. :)

3) "Fix to be conform[]" (sigh). Fix what? Changelogs (or "Commits messages") 
must be self-contained, so write them like if you expected that the Reviewers 
immediately forget what they read in the "Subject" line. While you are at it, 
please also correct grammar. 

(Finally, it is the Linux kernel maintainers and developers who have "style 
requirements", listed in the "Linux kernel coding style" document, instead 
checkpatch.pl has no requirements (it just checks for style violations)).

Thanks,

Fabio

> Signed-off-by: Michael Estner <michaelestner@....de>
> ---