linux-kernel - Re: [PATCH] avoid crashing the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7598246.TGqz6ispmn@localhost.localdomain>
Date:   Sun, 26 Sep 2021 10:38:57 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Estner <michaelestner@....de>
Cc:     michaelestner@....de, Lee Jones <lee.jones@...aro.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] avoid crashing the kernel

On Saturday, September 25, 2021 10:04:30 PM CEST Michael Estner wrote:
> To avoid chrashing the kernel I use WARN_ON instead.

"[] I use WARN_ON instead". Instead of what? 

Changelogs must be self-contained. I had to look at the diff to complete that 
sentence in my mind.

Please don't ask reviewers to go back and forth commit messages and code in 
order to get the whole picture.

However, my suggestion is only about the formal aspects of proper patch 
construction. The actual top priority is to properly solve this problem using 
the tips provided by Greg K-H with his review.
Thanks,

Fabio

P.S.: "chrashing" => "crashing".

> 
> Signed-off-by: Michael Estner <michaelestner@....de>
> ---
>  drivers/staging/most/i2c/i2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/
i2c.c
> index 7042f10887bb..e1edd892f9fd 100644
> --- a/drivers/staging/most/i2c/i2c.c
> +++ b/drivers/staging/most/i2c/i2c.c
> @@ -68,7 +68,7 @@ static int configure_channel(struct most_interface 
*most_iface,
>  	struct hdm_i2c *dev = to_hdm(most_iface);
>  	unsigned int delay, pr;
> 
> -	BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
> +	WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);