linux-kernel - Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dae80c3-034c-617b-c766-1858d6ee1220@protonmail.com>
Date:   Sun, 26 Sep 2021 08:44:56 +0000
From:   Orlando Chamberlain <redecorating@...tonmail.com>
To:     Aditya Garg <gargaditya08@...e.com>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "kbusch@...nel.org" <kbusch@...nel.org>
Cc:     "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "james.smart@...adcom.com" <james.smart@...adcom.com>,
        "chaitanya.kulkarni@....com" <chaitanya.kulkarni@....com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "trivial@...nel.org" <trivial@...nel.org>
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

On 26/9/21 18:07, Aditya Garg wrote:
> I checked out the proposal sent by Orlando Chamberlain to replace 
> NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch on 
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html 
> <http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html>. 
> The , still causes panics to the T2 as described before. In the case of |, the 
> kernel boots correctly without panicking the T2, but in case we are having Linux 
> on an External Drive, which is my case, then the internal SSD doesn't seem to be 
> recognised at all. I've tested the patch on 5.14.7. A screenshot of the GNOME 
> Disks utility has been attached along with this mail.

I had some issues with the patch not applying automatically as I mixed up tabs and spaces,
(due to me copying stuff directly out of vim), so I had issues with getting patches to apply
automatically. I've checked that this file https://github.com/Redecorating/mbp-16.1-linux-wifi/blob/anbox-bt/1001-apple-t2-disable-nvme-gen-counter-quirk.patch
applies correctly for me (and github ci), so can you see if it still doesn't work with that?