linux-kernel - Re: [PATCH] watchdog: s3c2410: describe driver in KConfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210926121350.GA3174183@roeck-us.net>
Date:   Sun, 26 Sep 2021 05:13:50 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: s3c2410: describe driver in KConfig

On Fri, Sep 24, 2021 at 03:29:30PM +0200, Krzysztof Kozlowski wrote:
> Describe better which driver applies to which SoC, to make configuring
> kernel for Samsung SoC easier.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/Kconfig | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index b81fe4f7d434..75591ba261e2 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -496,16 +496,18 @@ config S3C2410_WATCHDOG
>  	select WATCHDOG_CORE
>  	select MFD_SYSCON if ARCH_EXYNOS
>  	help
> -	  Watchdog timer block in the Samsung SoCs. This will reboot
> -	  the system when the timer expires with the watchdog enabled.
> +	  Watchdog timer block in the Samsung S3C24xx, S3C64xx, S5Pv210 and
> +	  Exynos SoCs. This will reboot the system when the timer expires with
> +	  the watchdog enabled.
>  
>  	  The driver is limited by the speed of the system's PCLK
>  	  signal, so with reasonably fast systems (PCLK around 50-66MHz)
>  	  then watchdog intervals of over approximately 20seconds are
>  	  unavailable.
>  
> +	  Choose Y/M here only if you build for such Samsung SoC.
>  	  The driver can be built as a module by choosing M, and will
> -	  be called s3c2410_wdt
> +	  be called s3c2410_wdt.
>  
>  config SA1100_WATCHDOG
>  	tristate "SA1100/PXA2xx watchdog"
> -- 
> 2.30.2
>