linux-kernel - Re: [PATCH v2 6/6] USB: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOY-YVk9_8zEXpW8XwTuEPVMxCUwpXemWmNzt2by90bnTv66YA@mail.gmail.com>
Date:   Sun, 26 Sep 2021 15:00:20 +0200
From:   Himadri Pandya <himadrispandya@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        USB list <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] USB: serial: kl5kusb105: use usb_control_msg_recv()
 and usb_control_msg_send()

On Tue, Sep 21, 2021 at 2:41 PM Johan Hovold <johan@...nel.org> wrote:
>
> On Mon, Aug 02, 2021 at 02:01:22AM +0530, Himadri Pandya wrote:
> > The wrappers usb_control_msg_send/recv eliminate the need of allocating
> > dma buffers for usb message. They also impose proper error checks on the
> > return value of usb_control_msg() to handle short read/write. Hence use
> > the wrappers and remove dma allocations.
> >
> > Signed-off-by: Himadri Pandya <himadrispandya@...il.com>
> > ---
> > Changes in v2:
> >  - Fix the caller of klsi_105_chg_port_settings()
> >  - Drop unnecessary use of the wrappers
>
> Now applied with an amended commit message:
>
>     USB: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg_send()
>
>     The wrappers usb_control_msg_send/recv eliminate the need of
>     manually allocating DMA buffers for USB messages. They also treat
>     short reads as an error. Hence use the wrappers and remove DMA
>     allocations.
>
>     Note that short reads are now logged as -EREMOTEIO instead of the amount
>     of data read.
>
> I've applied all but the first two patches in the series now. Would you
> mind respinning those two?
>
> Thanks,
> Johan

Thanks for reviewing and applying these patches. And yes, I'm sending
the revised version for the first two.

Regards,
Himadri