[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMo8Bf+TE4PX5PBD8bSsF6Cx+LGunExjuB3xXyyRvwzC0iHMDA@mail.gmail.com>
Date: Sun, 26 Sep 2021 11:55:57 -0700
From: Max Filippov <jcmvbkbc@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Chris Zankel <chris@...kel.net>,
"open list:TENSILICA XTENSA PORT (xtensa)"
<linux-xtensa@...ux-xtensa.org>
Subject: Re: [RFC PATCH] xtensa: setup: use CONFIG_USE_OF instead of CONFIG_OF
Hi Randy,
On Fri, Sep 24, 2021 at 8:29 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> CONFIG_OF can be set by a randconfig or by a user -- without setting the
> early flattree option (OF_EARLY_FLATTREE). This causes build errors.
> However, if randconfig or a user sets USE_OF in the Xtensa config,
> the right kconfig symbols are set to enable xtensa/kernel/setup.c to
> build.
>
> Fixes these build errors:
>
> ../arch/xtensa/kernel/setup.c: In function 'xtensa_dt_io_area':
> ../arch/xtensa/kernel/setup.c:201:14: error: implicit declaration of function 'of_flat_dt_is_compatible'; did you mean 'of_machine_is_compatible'? [-Werror=implicit-function-declaration]
> 201 | if (!of_flat_dt_is_compatible(node, "simple-bus"))
> ../arch/xtensa/kernel/setup.c:204:18: error: implicit declaration of function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration]
> 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len);
> ../arch/xtensa/kernel/setup.c:204:16: error: assignment to 'const __be32 *' {aka 'const unsigned int *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len);
> | ^
> ../arch/xtensa/kernel/setup.c: In function 'early_init_devtree':
> ../arch/xtensa/kernel/setup.c:228:9: error: implicit declaration of function 'early_init_dt_scan'; did you mean 'early_init_devtree'? [-Werror=implicit-function-declaration]
> 228 | early_init_dt_scan(params);
> ../arch/xtensa/kernel/setup.c:229:9: error: implicit declaration of function 'of_scan_flat_dt' [-Werror=implicit-function-declaration]
> 229 | of_scan_flat_dt(xtensa_dt_io_area, NULL);
>
> Fixes: da844a81779e ("xtensa: add device trees support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: linux-xtensa@...ux-xtensa.org
> ---
> arch/xtensa/kernel/setup.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks for your RFC. I've tested it and found a couple more places
where CONFIG_USE_OF should be used instead of CONFIG_OF.
I'll post the revised version.
--
Thanks.
-- Max
Powered by blists - more mailing lists