linux-kernel - Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210926032701.GA32606@L-PF27918B-1352.localdomain>
Date:   Sun, 26 Sep 2021 11:27:01 +0800
From:   Wu Zongyong <wuzongyong@...ux.alibaba.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, mst@...hat.com,
        wei.yang1@...ux.alibaba.com
Subject: Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

On Sun, Sep 26, 2021 at 10:26:47AM +0800, Jason Wang wrote:
> 
> 在 2021/9/22 下午8:46, Wu Zongyong 写道:
> > +
> > +#ifdef __LITTLE_ENDIAN
> 
> 
> I think disable the device via Kconfig is better than letting user to meet
> errors like this.
> 
> (Or if the device is always using little endian, we don't even need to
> bother this).

I prefer the second suggestion since there are no use cases that the
device uses big endian
> 
> Thanks
> 
> 
> > +static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > +{
> > +	struct device *dev = &pdev->dev;
> > +	struct eni_vdpa *eni_vdpa;
> > +	struct virtio_pci_legacy_device *ldev;
> > +	int ret, i;
> > +
> > +	ret = pcim_enable_device(pdev);
> > +	if (ret)
> > +		return ret;
> > +