linux-kernel - Re: [PATCH 0/5] Switchtec Fixes and Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ddbe6273acb215860fac5c2df83e54b48b0d1a5.camel@microchip.com>
Date:   Mon, 27 Sep 2021 18:25:33 +0000
From:   <Kelvin.Cao@...rochip.com>
To:     <helgaas@...nel.org>
CC:     <kurt.schwemmer@...rosemi.com>, <bhelgaas@...gle.com>,
        <kelvincao@...look.com>, <logang@...tatee.com>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 0/5] Switchtec Fixes and Improvements

On Mon, 2021-09-27 at 11:39 -0500, Bjorn Helgaas wrote:
> On Fri, Sep 24, 2021 at 11:08:37AM +0000, kelvin.cao@...rochip.com
> wrote:
> > From: Kelvin Cao <kelvin.cao@...rochip.com>
> > 
> > Hi,
> > 
> > Please find a bunch of patches for the switchtec driver collected
> > over the
> > last few months.
> > 
> > The first 2 patches fix two minor bugs. Patch 3 updates the method
> > of
> > getting management VEP instance ID based on a new firmware change.
> > Patch
> > 4 replaces ENOTSUPP with EOPNOTSUPP to follow the preference of
> > kernel.
> > And the last patch adds check of event support to align with new
> > firmware
> > implementation.
> > 
> > This patchset is based on v5.15-rc2.
> > 
> > Thanks,
> > Kelvin
> > 
> > Kelvin Cao (4):
> >   PCI/switchtec: Error out MRPC execution when no GAS access
> >   PCI/switchtec: Fix a MRPC error status handling issue
> >   PCI/switchtec: Update the way of getting management VEP instance
> > ID
> >   PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP
> > 
> > Logan Gunthorpe (1):
> >   PCI/switchtec: Add check of event support
> > 
> >  drivers/pci/switch/switchtec.c | 87 +++++++++++++++++++++++++++---
> > ----
> >  include/linux/switchtec.h      |  1 +
> >  2 files changed, 71 insertions(+), 17 deletions(-)
> 
> Applied with Logan's reviewed-by to pci/switchtec for v5.16, thanks!
> 
> I tweaked the comment spacing in "PCI/switchtec: Error out MRPC
> execution when no GAS access" so it matches the existing similar
> comments.

Thanks for your time!

I guess the tweak was made to "PCI/switchtec: Replace ENOTSUPP with
EOPNOTSUPP" which also confirmed that "Link:" tag should not be put to
a discussion reference URL line in the comment.

Kelvin