linux-kernel - Re: [PATCH v2 0/3] fs/ntfs3: Refactoring of xattr.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210927190201.yhlipxcitremds3e@kari-VirtualBox>
Date:   Mon, 27 Sep 2021 22:02:01 +0300
From:   Kari Argillander <kari.argillander@...il.com>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] fs/ntfs3: Refactoring of xattr.c

On Mon, Sep 27, 2021 at 06:26:26PM +0300, Konstantin Komarov wrote:
> Removed function, that already have been in kernel.
> Changed locking policy to fix some potential bugs.
> Changed code for readability.
> 
> V2:
>   fixed typo.

In the future please tell more closly. Now reviewr has to check
everything again. It is also good thing to write if someone suggest it.
Then that person can see right away that you change what he/she
suggested.

Also usually when someone comment something to previes series version
then you take all commenters to cc list. Usually reviewer will might
wanna give reviewed-by tag after you change what suggested.

> 
> Konstantin Komarov (3):
>   fs/ntfs3: Use available posix_acl_release instead of
>     ntfs_posix_acl_release
>   fs/ntfs3: Remove locked argument in ntfs_set_ea
>   fs/ntfs3: Refactoring of ntfs_set_ea
> 
>  fs/ntfs3/xattr.c | 69 ++++++++++++++++++++++--------------------------
>  1 file changed, 32 insertions(+), 37 deletions(-)
> 
> -- 
> 2.33.0
>