linux-kernel - Re: [PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5GVpm2PeKkHxnn4gd_WE_Pyoij1RjYiJbAMnyze6RT5oQ@mail.gmail.com>
Date:   Mon, 27 Sep 2021 15:17:19 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Heiko Stübner <heiko@...ech.de>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sandy Huang <hjc@...k-chips.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Thomas Hebb <tommyhebb@...il.com>
Subject: Re: [PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error

On Sat, Sep 25, 2021 at 7:24 AM Brian Norris <briannorris@...omium.org> wrote:
>
> Our probe() function never enabled this clock, so we shouldn't disable
> it if we fail to probe the bridge.
>
> Noted by inspection.
>
> Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver")
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>