linux-kernel - Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Sep 2021 14:52:48 -0500
From:   Rob Herring <robh@...nel.org>
To:     Daniel Palmer <daniel@...f.com>
Cc:     devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-leds@...r.kernel.org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, pavel@....cz,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger

On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote:
> The "activity" trigger can be used as the default but it's currently
> undocumented so validating a devicetree that uses it causes a warning.

It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some 
reason that can't be used?

> 
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 697102707703..8160a5073728 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -80,6 +80,8 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/string
>  
>      enum:
> +        # LED will flashing will represent current CPU usage
> +      - activity
>          # LED will act as a back-light, controlled by the framebuffer system
>        - backlight
>          # LED will turn on (but for leds-gpio see "default-state" property in
> -- 
> 2.33.0
> 
>