linux-kernel - Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ASDXMyaWfg07UEcbN_N4WBK=PzVO+SnwZ=VnjL2hJDWvOxDw@mail.gmail.com>
Date:   Mon, 27 Sep 2021 12:57:33 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Tom Hebb <tommyhebb@...il.com>
Cc:     Heiko Stübner <heiko@...ech.de>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Chen-Yu Tsai <wenst@...omium.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Sandy Huang <hjc@...k-chips.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        aleksandr.o.makarov@...il.com, stable <stable@...r.kernel.org>,
        Nícolas F . R . A . Prado 
        <nfraprado@...labora.com>
Subject: Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

On Mon, Sep 27, 2021 at 12:18 PM Tom Hebb <tommyhebb@...il.com> wrote:
> Reviewed-by: Thomas Hebb <tommyhebb@...il.com>

Thanks!

> Thank you for catching this, and sorry that my original fix broke things.
> There had actually been a report of this breakage from my patch, but I
> missed that email until it had already been merged and then didn't have
> time to follow up on it. Totally my bad.

No worries. It was a 1 step forward, 1 step backward kind of a thing
anyway -- things were broken in many cases before your patch too (with
very similar-looking symptoms) -- so the net result is still good,
having both issues fixed.

I'm not sure how that ideally should have been handled [1], but it's
totally fair to not have time to follow up on everything. At the
worst, we could have reverted things; but again, I'm pretty sure
things were broken just as well without your fix, just with a
different root cause.

Regards,
Brian

[1] Don't accept (or, revert?) your bugfix until what may or may not
have been a regression is fixed? I'm not sure.