linux-kernel - Re: [RFC] arm64: mm: update max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c83b7e80-0a16-d83f-f3f4-ab0b32c7753b@quicinc.com>
Date:   Mon, 27 Sep 2021 23:00:25 +0300
From:   Georgi Djakov <quic_c_gdjako@...cinc.com>
To:     David Hildenbrand <david@...hat.com>,
        Chris Goldsworthy <quic_cgoldswo@...cinc.com>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        Sudarshan Rajagopalan <quic_sudaraja@...cinc.com>
Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug

On 9/27/2021 8:34 PM, David Hildenbrand wrote:
> On 27.09.21 19:22, Georgi Djakov wrote:
>> On 9/24/2021 1:54 AM, Chris Goldsworthy wrote:
>>> From: Sudarshan Rajagopalan <quic_sudaraja@...cinc.com>
>>>
>>> After new memory blocks have been hotplugged, max_pfn and max_low_pfn
>>> needs updating to reflect on new PFNs being hot added to system.
>>>
>>> Signed-off-by: Sudarshan Rajagopalan <quic_sudaraja@...cinc.com>
>>> Signed-off-by: Chris Goldsworthy <quic_cgoldswo@...cinc.com>
>>
>> Thanks for the patch, Chris!
>>
>> With this patch, the data in /proc/kpageflags appears to be correct and
>> memory tools like procrank work again on arm64 platforms.
>>
>> Tested-by: Georgi Djakov <quic_c_gdjako@...cinc.com>
>>
>> Maybe we should add fixes tag, as it has been broken since the following
>> commit:
>> Fixes: abec749facff ("fs/proc/page.c: allow inspection of last section
>> and fix end detection")
> 
> Are you sure that that commit broke it?

Reverting the above commit also "fixes" kpageflags, otherwise
kpageflags_read() returns 0 in the following check:
	if (src >= max_dump_pfn * KPMSIZE)
		return 0;

> I recall that we would naturally run into the limit, because
> 
> count = min_t(size_t, count, (max_pfn * KPMSIZE) - src);

The function returns before we reach this line.

Thanks,
Georgi

> wouldn't really do what you would expect either. But you could 
> force-read beyond max_pfn, yes, because the count computation was just 
> weird.
> 
> 
> I think the real issue is not properly adjusting max_pfn in the first 
> place when we introduced memoruy hotplug on arm64