linux-kernel - Re: [PATCH] [RFC] mtd: fixup CFI on ixp4xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0WnM7_6o0FE3=iY+0J1-qU5gCGH6qWCfLygGTkH0TA+w@mail.gmail.com>
Date:   Mon, 27 Sep 2021 22:30:58 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Linus Walleij <linusw@...nel.org>,
        Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Arnd Bergmann <arnd@...db.de>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RFC] mtd: fixup CFI on ixp4xx

On Mon, Sep 27, 2021 at 6:33 PM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>
> Hi Arnd,
>
> arnd@...nel.org wrote on Mon, 27 Sep 2021 16:10:37 +0200:
>
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > drivers/mtd/maps/ixp4xx.c requires MTD_CFI_BE_BYTE_SWAP to be set
> > in order to compile.
> >
> > drivers/mtd/maps/ixp4xx.c:57:4: error: #error CONFIG_MTD_CFI_BE_BYTE_SWAP required
> >
> > This patch avoids the #error output by enforcing the policy in
> > Kconfig. Not sure if this is the right approach, but it helps doing
> > randconfig builds.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> > Any other ideas for how to address it?
>
> I am fine with the approach. Should I wait for someone else's Ack?

Maybe wait a few days to see if there are objections or any better
ideas then. I'd certainly be happy to never run into this problem again.

         Arnd