linux-kernel - drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202109280604.lsuCTD7N-lkp@intel.com>
Date:   Tue, 28 Sep 2021 06:13:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zhenyu Wang <zhenyuw@...ux.intel.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Colin Xu <colin.xu@...el.com>,
        linux-doc@...r.kernel.org
Subject: drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts
 with '/**', but isn't a kernel-doc comment. Refer
 Documentation/doc-guide/kernel-doc.rst

Hi Zhenyu,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   92477dd1faa650e50bd3bb35a6c0b8d09198cc35
commit: 145e06b58f8625becc61792a0554726314297a85 drm/i915/gvt: Move mdev attribute groups into kvmgt module
date:   4 months ago
config: x86_64-randconfig-a016-20210927 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=145e06b58f8625becc61792a0554726314297a85
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 145e06b58f8625becc61792a0554726314297a85
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Check if can do 2M page
   drivers/gpu/drm/i915/gvt/gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead


vim +1152 drivers/gpu/drm/i915/gvt/gtt.c

2707e44466881d6 Zhi Wang          2016-03-28  1150  
b901b252b6cf5ce Changbin Du       2018-05-15  1151  /**
a752b070a678231 Zhenyu Wang       2018-07-31 @1152   * Check if can do 2M page
a752b070a678231 Zhenyu Wang       2018-07-31  1153   * @vgpu: target vgpu
a752b070a678231 Zhenyu Wang       2018-07-31  1154   * @entry: target pfn's gtt entry
a752b070a678231 Zhenyu Wang       2018-07-31  1155   *
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1156   * Return 1 if 2MB huge gtt shadowing is possible, 0 if miscondition,
9317f356df83a5c Bhaskar Chowdhury 2021-02-22  1157   * negative if found err.
b901b252b6cf5ce Changbin Du       2018-05-15  1158   */
b901b252b6cf5ce Changbin Du       2018-05-15  1159  static int is_2MB_gtt_possible(struct intel_vgpu *vgpu,
b901b252b6cf5ce Changbin Du       2018-05-15  1160  	struct intel_gvt_gtt_entry *entry)
b901b252b6cf5ce Changbin Du       2018-05-15  1161  {
b901b252b6cf5ce Changbin Du       2018-05-15  1162  	struct intel_gvt_gtt_pte_ops *ops = vgpu->gvt->gtt.pte_ops;
b901b252b6cf5ce Changbin Du       2018-05-15  1163  	unsigned long pfn;
b901b252b6cf5ce Changbin Du       2018-05-15  1164  
a61ac1e75105a07 Chris Wilson      2020-03-06  1165  	if (!HAS_PAGE_SIZES(vgpu->gvt->gt->i915, I915_GTT_PAGE_SIZE_2M))
b901b252b6cf5ce Changbin Du       2018-05-15  1166  		return 0;
b901b252b6cf5ce Changbin Du       2018-05-15  1167  
b901b252b6cf5ce Changbin Du       2018-05-15  1168  	pfn = intel_gvt_hypervisor_gfn_to_mfn(vgpu, ops->get_pfn(entry));
b901b252b6cf5ce Changbin Du       2018-05-15  1169  	if (pfn == INTEL_GVT_INVALID_ADDR)
b901b252b6cf5ce Changbin Du       2018-05-15  1170  		return -EINVAL;
b901b252b6cf5ce Changbin Du       2018-05-15  1171  
b901b252b6cf5ce Changbin Du       2018-05-15  1172  	return PageTransHuge(pfn_to_page(pfn));
b901b252b6cf5ce Changbin Du       2018-05-15  1173  }
b901b252b6cf5ce Changbin Du       2018-05-15  1174  

:::::: The code at line 1152 was first introduced by commit
:::::: a752b070a67823174565322cc48b2668daf9a8da drm/i915/gvt: Fix function comment doc errors

:::::: TO: Zhenyu Wang <zhenyuw@...ux.intel.com>
:::::: CC: Zhenyu Wang <zhenyuw@...ux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37699 bytes)