linux-kernel - Re: [PATCH v4 12/13] blk-mq: Use shared tags for shared sbitmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a89ae671-c455-1b05-d140-82d4a90507f6@huawei.com>
Date:   Mon, 27 Sep 2021 10:41:16 +0100
From:   John Garry <john.garry@...wei.com>
To:     Ming Lei <ming.lei@...hat.com>
CC:     <axboe@...nel.dk>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <hare@...e.de>
Subject: Re: [PATCH v4 12/13] blk-mq: Use shared tags for shared sbitmap
 support

On 27/09/2021 10:26, Ming Lei wrote:
>>>> -	struct sbitmap_queue	sched_bitmap_tags;
>>>> -	struct sbitmap_queue	sched_breserved_tags;
>>>> +	struct blk_mq_tags	*shared_sbitmap_tags;
>>> Maybe better with shared_sched_sbitmap_tags or sched_sbitmap_tags?
>> Yeah, I suppose I should add "sched" to the name, as before.
>>
>> BTW, Do you think that I should just change shared_sbitmap -> shared_tags
>> naming now globally? I'm thinking now that I should...
> Yeah, I think so, but seems you preferred to the name of shared sbitmap, so I
> did't mention that,:-)

OK, I can clear up any references in a follow on patch to try to keep 
this one as small as possible.

Thanks,
John