linux-kernel - About the "__refdata" tag in pci-keystone.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210927103321.v4kod7xfiv5sreet@lony.xyz>
Date:   Mon, 27 Sep 2021 12:33:21 +0200
From:   "Sergio M. Iglesias" <sergio@...y.xyz>
To:     bhelgaas@...gle.com
Cc:     lorenzo.pieralisi@....com, robh@...nel.org, kw@...ux.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: About the "__refdata" tag in pci-keystone.c

Hello!

I have checked the "__refdata" tag that appears in the file
"drivers/pci/controller/dwc/pci-keystone.c" and it is needed. The tag has
been there since the creation of the file on commit 6e0832fa432e and
nothing has changed since that would make it redundant.

The reason it is needed is because the struct references "ks_pcie_probe",
which is a function tagged as "__init", so the compiler will most likely
complain about the "__refdata" being removed.

Should I send a patch to add a comment explaining why it is a necessary
tag as recommended in "include/linux/init.h"?
> [...] so optimally document why the __ref is needed and why it's OK).

Thanks for your time,
Sergio M. Iglesias.