linux-kernel - Re: [PATCH] ASoC: wcd9335: Use correct version to initialize Class H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43d70ca3-bd14-c83a-12df-8cd64056256a@linaro.org>
Date:   Mon, 27 Sep 2021 12:00:45 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Yassine Oudjana <y.oudjana@...tonmail.com>,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wcd9335: Use correct version to initialize Class H



On 25/09/2021 03:24, Yassine Oudjana wrote:
> The versioning scheme was changed in an earlier patch, which caused the version
> being used to initialize WCD9335 to be interpreted as if it was WCD937X, which
> changed code paths causing broken headphones output. Pass WCD9335 instead of
> WCD9335_VERSION_2_0 to wcd_clsh_ctrl_alloc to fix it.
> 
> Fixes: 19c5d1f6a0c3 ("ASoC: codecs: wcd-clsh: add new version support")
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> ---

Thanks for the fix,

LGTM,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

--srini


>   sound/soc/codecs/wcd9335.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index d885ced34f60..bc5d68c53e5a 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -4859,7 +4859,7 @@ static int wcd9335_codec_probe(struct snd_soc_component *component)
>   
>   	snd_soc_component_init_regmap(component, wcd->regmap);
>   	/* Class-H Init*/
> -	wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, wcd->version);
> +	wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, WCD9335);
>   	if (IS_ERR(wcd->clsh_ctrl))
>   		return PTR_ERR(wcd->clsh_ctrl);
>   
>