[<prev] [next>] [day] [month] [year] [list]
Message-ID: <6bec8a71-2233-9549-ab5e-1b1f62e2f488@redhat.com>
Date: Mon, 27 Sep 2021 13:51:16 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Longji Guo <guolongji@...ontech.com>, gregkh@...uxfoundation.org,
fabioaiuto83@...il.com
Cc: ross.schm.dev@...il.com, marcocesati@...il.com,
fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove meaningless pstat->passoc_req
check in OnAssocReq()
Hi,
On 9/27/21 1:49 PM, Longji Guo wrote:
> kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree
> is not necessary.
>
> Signed-off-by: Longji Guo <guolongji@...ontech.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>
Next time please mark a new (v2) version as such please by changing
the [PATCH] in the subject to [PATCH v2].
You can do this, by for example doing:
git format-patch -v2 HEAD~
git send-email v2-0001-.....patch
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 375d2a742dd2..51390a30fa55 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1344,12 +1344,8 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
> issue_asocrsp(padapter, status, pstat, WIFI_REASSOCRSP);
>
> spin_lock_bh(&pstat->lock);
> - if (pstat->passoc_req) {
> - kfree(pstat->passoc_req);
> - pstat->passoc_req = NULL;
> - pstat->assoc_req_len = 0;
> - }
> -
> + kfree(pstat->passoc_req);
> + pstat->assoc_req_len = 0;
> pstat->passoc_req = rtw_zmalloc(pkt_len);
> if (pstat->passoc_req) {
> memcpy(pstat->passoc_req, pframe, pkt_len);
>
Powered by blists - more mailing lists