linux-kernel - Re: [patch 06/11] power: reset: ltc2952: Use hrtimer_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210927123409.sl2ekpr3kcfqydar@earth.universe>
Date:   Mon, 27 Sep 2021 14:34:09 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>, linux-pm@...r.kernel.org
Subject: Re: [patch 06/11] power: reset: ltc2952: Use hrtimer_forward_now()

Hi,

On Thu, Sep 23, 2021 at 06:04:28PM +0200, Thomas Gleixner wrote:
> hrtimer_forward_now() provides the same functionality as the open coded
> hrtimer_forward() invocation. Prepares for removal of hrtimer_forward()
> from the public interfaces.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: linux-pm@...r.kernel.org
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

>  drivers/power/reset/ltc2952-poweroff.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/drivers/power/reset/ltc2952-poweroff.c
> +++ b/drivers/power/reset/ltc2952-poweroff.c
> @@ -94,7 +94,6 @@ static struct ltc2952_poweroff *ltc2952_
>   */
>  static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
>  {
> -	ktime_t now;
>  	int state;
>  	struct ltc2952_poweroff *data = to_ltc2952(timer, timer_wde);
>  
> @@ -104,8 +103,7 @@ static enum hrtimer_restart ltc2952_powe
>  	state = gpiod_get_value(data->gpio_watchdog);
>  	gpiod_set_value(data->gpio_watchdog, !state);
>  
> -	now = hrtimer_cb_get_time(timer);
> -	hrtimer_forward(timer, now, data->wde_interval);
> +	hrtimer_forward_now(timer, data->wde_interval);
>  
>  	return HRTIMER_RESTART;
>  }
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)