linux-kernel - 答复: [PATCH] sched/core: return prio_less() directly in __sched_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1355610eac946439cf5799a7d48d2bf@baidu.com>
Date:   Mon, 27 Sep 2021 13:08:24 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH] sched/core: return prio_less() directly in __sched_core_less

Ping

-Li

> -----邮件原件-----
> 发件人: Li,Rongqing <lirongqing@...du.com>
> 发送时间: 2021年8月24日 18:19
> 收件人: mingo@...hat.com; peterz@...radead.org; juri.lelli@...hat.com;
> vincent.guittot@...aro.org; linux-kernel@...r.kernel.org; Li,Rongqing
> <lirongqing@...du.com>
> 主题: [PATCH] sched/core: return prio_less() directly in __sched_core_less
> 
> return prio_less() directly to avoid unnecessary checking
> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> ---
>  kernel/sched/core.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 2d9ff40..73478c9
> 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -140,10 +140,7 @@ static inline bool __sched_core_less(struct task_struct
> *a, struct task_struct *
>  		return false;
> 
>  	/* flip prio, so high prio is leftmost */
> -	if (prio_less(b, a, task_rq(a)->core->core_forceidle))
> -		return true;
> -
> -	return false;
> +	return prio_less(b, a, task_rq(a)->core->core_forceidle);
>  }
> 
>  #define __node_2_sc(node) rb_entry((node), struct task_struct, core_node)
> --
> 1.7.1