linux-kernel - Re: [PATCH] [RESEND] ARM: sharpsl_param: work around -Wstringop-overread warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 27 Sep 2021 16:55:13 +0200
From:   Daniel Mack <daniel@...que.org>
To:     Arnd Bergmann <arnd@...nel.org>, soc@...nel.org
Cc:     Arnd Bergmann <arnd@...db.de>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell King <linux@...linux.org.uk>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] ARM: sharpsl_param: work around
 -Wstringop-overread warning

On 9/27/21 4:53 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> gcc warns that accessing a pointer based on a numeric constant may
> be an offset into a NULL pointer, and would therefore has zero
> accessible bytes:
> 
> arch/arm/common/sharpsl_param.c: In function ‘sharpsl_save_param’:
> arch/arm/common/sharpsl_param.c:43:9: error: ‘memcpy’ reading 64 bytes from a region of size 0 [-Werror=stringop-overread]
>    43 |         memcpy(&sharpsl_param, param_start(PARAM_BASE), sizeof(struct sharpsl_param_info));
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> In this particular case, the warning is bogus since this is the actual
> pointer, not an offset on a NULL pointer. Add a local variable to shut
> up the warning and hope it doesn't come back.
> 
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578

Acked-by: Daniel Mack <daniel@...que.org>


> Cc: Haojian Zhuang <haojian.zhuang@...il.com>
> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> If there are no objections, I'd apply this one through the soc tree.
> ---
>  arch/arm/common/sharpsl_param.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/common/sharpsl_param.c b/arch/arm/common/sharpsl_param.c
> index efeb5724d9e9..6237ede2f0c7 100644
> --- a/arch/arm/common/sharpsl_param.c
> +++ b/arch/arm/common/sharpsl_param.c
> @@ -40,7 +40,9 @@ EXPORT_SYMBOL(sharpsl_param);
>  
>  void sharpsl_save_param(void)
>  {
> -	memcpy(&sharpsl_param, param_start(PARAM_BASE), sizeof(struct sharpsl_param_info));
> +	struct sharpsl_param_info *params = param_start(PARAM_BASE);
> +
> +	memcpy(&sharpsl_param, params, sizeof(*params));
>  
>  	if (sharpsl_param.comadj_keyword != COMADJ_MAGIC)
>  		sharpsl_param.comadj=-1;
>