linux-kernel - Re: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVHilhCk3cgGhXrZ@kroah.com>
Date:   Mon, 27 Sep 2021 17:26:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        Yujia Qiao <rapiz@...mail.com>,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        Marcos Antonio de Jesus Filho <mdejesusfilho@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Deepak R Varma <mh12gx2825@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime

On Sun, Sep 26, 2021 at 06:25:18PM +0200, Tommaso Merciai wrote:
> Replace camel case variable bShortSlotTime with snake case
> variable b_short_slot_time.

That is a very odd variable name.  Why did you pick that one?

What deos it mean?

You do understand where the original naming format came from here, and
what it was trying to represent, right?  If not, please go read up on
it:
	https://en.wikipedia.org/wiki/Hungarian_notation

That style is not used in Linux, and so, when converting from it, do not
attempt to keep the same style present here, that is kind of pointless,
don't you agree?

thanks,

greg k-h