linux-kernel - Re: [PATCH] nvme: add command id quirk for apple controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aea8dabd-4c5f-3183-89a3-b2019d004ded@kernel.dk>
Date:   Mon, 27 Sep 2021 09:39:29 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
        sagi@...mberg.me, hch@....de
Cc:     linux-kernel@...r.kernel.org, Sven Peter <sven@...npeter.dev>,
        Orlando Chamberlain <redecorating@...tonmail.com>,
        Aditya Garg <gargaditya08@...e.com>
Subject: Re: [PATCH] nvme: add command id quirk for apple controllers

On 9/27/21 9:35 AM, Keith Busch wrote:
> @@ -1026,7 +1027,8 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
>  		return BLK_STS_IOERR;
>  	}
>  
> -	nvme_req(req)->genctr++;
> +	if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
> +		nvme_req(req)->genctr++;

This doesn't look right, as it'll never be true...

-- 
Jens Axboe