linux-kernel - Re: [PATCHv2] nvme: add command id quirk for apple controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <df160284-55cb-4642-abc5-65f6aa61b48d@www.fastmail.com>
Date:   Mon, 27 Sep 2021 17:59:40 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Keith Busch" <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
        "sagi@...mberg.me" <sagi@...mberg.me>, "hch@....de" <hch@....de>
Cc:     linux-kernel@...r.kernel.org, axboe@...nel.dk,
        "Orlando Chamberlain" <redecorating@...tonmail.com>,
        "Aditya Garg" <gargaditya08@...e.com>
Subject: Re: [PATCHv2] nvme: add command id quirk for apple controllers



On Mon, Sep 27, 2021, at 17:43, Keith Busch wrote:
> Some apple controllers use the command id as an index to implementation
> specific data structures and will fail if the value is out of bounds.
> The nvme driver's recently introduced command sequence number breaks
> this controller.
>
> Provide a quirk so these spec incompliant controllers can function as
> before. The driver will not have the ability to detect bad completions
> when this quirk is used, but we weren't previously checking this anyway.
>
> The quirk bit was selected so that it can readily apply to stable.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=214509
> Cc: Sven Peter <sven@...npeter.dev>
> Reported-by: Orlando Chamberlain <redecorating@...tonmail.com>
> Reported-by: Aditya Garg <gargaditya08@...e.com>
> Signed-off-by: Keith Busch <kbusch@...nel.org>
> ---
> v1->v2: fixed logical bug checking the quirk setting
>
>  drivers/nvme/host/core.c | 4 +++-
>  drivers/nvme/host/nvme.h | 6 ++++++
>  drivers/nvme/host/pci.c  | 3 ++-
>  3 files changed, 11 insertions(+), 2 deletions(-)

Looks good to me, on the M1 with my out-of-tree driver:

Tested-by: Sven Peter <sven@...npeter.dev>



Thanks,


Sven