linux-kernel - Re: [PATCH] aio: convert active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YVHuMnfxEgQxB2/i@infradead.org>
Date:   Mon, 27 Sep 2021 17:15:46 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Hamza Mahfooz <someguy@...ective-light.com>
Cc:     linux-kernel@...r.kernel.org, Benjamin LaHaise <bcrl@...ck.org>,
        Alexander Viro <viro@...iv.linux.org.uk>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] aio: convert active_reqs into an array

On Mon, Sep 27, 2021 at 12:10:47PM -0400, Hamza Mahfooz wrote:
> Commit 833f4154ed56 ("aio: fold lookup_kiocb() into its sole caller")
> suggests that, the fact that active_reqs is a linked-list means aio_kiocb
> lookups in io_cancel() are inefficient. So, to get faster lookups while
> maintaining similar characteristics elsewhere, turn active_reqs into an
> array and keep track of the free indices of the array (so we know which
> indices are safe to use).

As requested last time: please explain what workload you have where
cancellation performance actually matters.