linux-kernel - Re: [PATCH 10/17] ABI: sysfs-bus-pci: add a alternative What fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Sep 2021 13:34:03 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Amey Narkhede <ameynarkhede03@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Carlos Bilbao <bilbao@...edu>,
        Leon Romanovsky <leon@...nel.org>,
        Maximilian Luz <luzmaximilian@...il.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/17] ABI: sysfs-bus-pci: add a alternative What fields

Probably already queued up, but:

s/add a alternative/add alternative/ (in subject)

On Mon, Sep 27, 2021 at 03:59:43PM +0200, Mauro Carvalho Chehab wrote:
> There are some PCI ABI that aren't shown under:
> 
> 	/sys/bus/pci/drivers/.../
> 
> Because they're registered with a different class. That's
> the case of, for instance:
> 
> 	/sys/bus/i2c/drivers/CHT Whiskey Cove PMIC/unbind
> 
> This one is not present under /sys/bus/pci:
> 
> 	$ find /sys/bus/pci -name 'CHT Whiskey Cove PMIC'
> 
> Although clearly this is provided by a PCI driver:
> 
> 	/sys/devices/pci0000:00/0000:00:02.0/i2c-4/subsystem/drivers/CHT Whiskey Cove PMIC/unbind
> 
> So, add an altertate What location in order to match bind/unbind
> to such devices.

s/altertate/alternate/

> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
> 
> See [PATCH 00/17] at: https://lore.kernel.org/all/cover.1632750608.git.mchehab+huawei@kernel.org/
> 
>  Documentation/ABI/testing/sysfs-bus-pci | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
> index 1eeac7f59672..16afe3f59cbd 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -1,4 +1,5 @@
>  What:		/sys/bus/pci/drivers/.../bind
> +What:		/sys/devices/pciX/.../bind

Wasn't somebody just updating these wildcard-ish items in pathnames?

Ah, it was you :)

  https://lore.kernel.org/all/4ede4ec98e295f054f3e5a6f3f9393b5e3d5d2a7.1631782432.git.mchehab+huawei@kernel.org/

Changing "virtfnN" to "virtfn<N>".

Is that same sort of thing applicable here?  My system has

  /sys/devices/pci0000:00/...

Bjorn