linux-kernel - Re: [GIT pull] x86/urgent for v5.15-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whSHDmcAbe=1AhRC8D8WcT6DpCP59kgjZc-wa8TfhxMiw@mail.gmail.com>
Date:   Tue, 28 Sep 2021 13:13:49 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [GIT pull] x86/urgent for v5.15-rc3

On Tue, Sep 28, 2021 at 10:56 AM Borislav Petkov <bp@...en8.de> wrote:
>
> Ok, how does that look?

Well, cleaner.

You lost the leXX_to_cpu() part, so now it does the wrong thing if you
were to cross-build the tooling side on a BE architecture.

The actual kernel side is fine, of course, since it runs on x86 by definition.

So it's purely the tool side - I assume this instruction decoding is
used for objtool or something.

I'm not sure that matters. BE is dead, nobody would ever cross-build
tooling that way. But maybe a compile-time error, at least, so that
the problem is obvious.

            Linus