linux-kernel - Re: [PATCH v2] kunit: fix reference count leak in kfree_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFd5g45mgi-bnTEiHshpyxnah74toncgCgmcQcHq=kP3L3r+Vw@mail.gmail.com>
Date:   Tue, 28 Sep 2021 14:27:30 -0700
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>
Cc:     linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, yuanxzhang@...an.edu.cn,
        Xin Tan <tanxin.ctf@...il.com>
Subject: Re: [PATCH v2] kunit: fix reference count leak in kfree_at_end

On Thu, Sep 9, 2021 at 12:26 AM Xiyu Yang <xiyuyang19@...an.edu.cn> wrote:
>
> The reference counting issue happens in the normal path of
> kfree_at_end(). When kunit_alloc_and_get_resource() is invoked, the
> function forgets to handle the returned resource object, whose refcount
> increased inside, causing a refcount leak.
>
> Fix this issue by calling kunit_alloc_resource() instead of
> kunit_alloc_and_get_resource().
>
> Signed-off-by: Xiyu Yang <xiyuyang19@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>

Thanks!