linux-kernel - Re: [PATCH v2 2/2] scsi: ufs: core: Fix a non-constant function argument name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d769cc3c-15ea-7c07-eeaa-e938b8d8483f@acm.org>
Date:   Tue, 28 Sep 2021 15:15:10 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <huobean@...il.com>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org,
        daejun7.park@...sung.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: ufs: core: Fix a non-constant function
 argument name

On 9/28/21 2:41 PM, Bean Huo wrote:
> From: Bean Huo <beanhuo@...ron.com>
> 
> Since commit 568dd9959611 ("scsi: ufs: Rename the second
> ufshcd_probe_hba() argument"), the second ufshcd_probe_hba()
> argument has been changed to init_dev_params.
> 
> Fixes: 568dd9959611 ("scsi: ufs: Rename the second ufshcd_probe_hba() argument")
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>   drivers/scsi/ufs/ufshcd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index debef631c89a..081092418e2d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -225,7 +225,7 @@ static int ufshcd_eh_host_reset_handler(struct scsi_cmnd *cmd);
>   static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag);
>   static void ufshcd_hba_exit(struct ufs_hba *hba);
>   static int ufshcd_clear_ua_wluns(struct ufs_hba *hba);
> -static int ufshcd_probe_hba(struct ufs_hba *hba, bool async);
> +static int ufshcd_probe_hba(struct ufs_hba *hba, bool init_dev_params);
>   static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on);
>   static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba);
>   static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba *hba);

What is a "non-constant function argument name"?

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>