linux-kernel - Re: [PATCHv2] nvme: add command id quirk for apple controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38101793-e0b9-ecf4-d235-465cb8e334b3@protonmail.com>
Date:   Tue, 28 Sep 2021 03:55:48 +0000
From:   Orlando Chamberlain <redecorating@...tonmail.com>
To:     Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
        sagi@...mberg.me, hch@....de
Cc:     linux-kernel@...r.kernel.org, axboe@...nel.dk,
        Sven Peter <sven@...npeter.dev>,
        Aditya Garg <gargaditya08@...e.com>
Subject: Re: [PATCHv2] nvme: add command id quirk for apple controllers



On 28/9/21 01:43, Keith Busch wrote:
> Some apple controllers use the command id as an index to implementation
> specific data structures and will fail if the value is out of bounds.
> The nvme driver's recently introduced command sequence number breaks
> this controller.
> 
> Provide a quirk so these spec incompliant controllers can function as
> before. The driver will not have the ability to detect bad completions
> when this quirk is used, but we weren't previously checking this anyway.
> 
> The quirk bit was selected so that it can readily apply to stable.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=214509
> Cc: Sven Peter <sven@...npeter.dev>
> Reported-by: Orlando Chamberlain <redecorating@...tonmail.com>
> Reported-by: Aditya Garg <gargaditya08@...e.com>
> Signed-off-by: Keith Busch <kbusch@...nel.org>
> ---
> v1->v2: fixed logical bug checking the quirk setting
> 
>  drivers/nvme/host/core.c | 4 +++-
>  drivers/nvme/host/nvme.h | 6 ++++++
>  drivers/nvme/host/pci.c  | 3 ++-
>  3 files changed, 11 insertions(+), 2 deletions(-)

Works on my MacBookPro16,1.

Tested-by: Orlando Chamberlain <redecorating@...tonmail.com>