linux-kernel - Re: [PATCH] media: videobuf2: always set buffer vb2 pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5HaZcf-RwGGb7phfKcoTnaeiN2H6b_BvR+qdcRYys=nzA@mail.gmail.com>
Date:   Tue, 28 Sep 2021 14:24:54 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Tomasz Figa <tfiga@...omium.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: videobuf2: always set buffer vb2 pointer

On Tue, Sep 28, 2021 at 2:16 PM Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> We need to always link allocated vb2_dc_buf back to vb2_buffer because
> we dereference vb2 in prepare() and finish() callbacks.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>

This fixes the breakage from the "videobuf2: support new noncontiguous DMA
API" series on the RK3399 Scarlet if the ChromeOS patch that changes
min_buffers_needed to 0 [1] is not applied.

Since there are other in-tree drivers that have min_buffers_needed=0,
I would recommend getting some more testing.

ChenYu

[1] https://crrev.com/c/3168489