linux-kernel - Re: [PATCH] s390/sclp_vt220: fix unused function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YVLTM38zdOZJKdmI@osiris>
Date:   Tue, 28 Sep 2021 10:32:51 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390/sclp_vt220: fix unused function warning

On Mon, Sep 27, 2021 at 02:56:47PM -0700, Randy Dunlap wrote:
> When CONFIG_SCLP_VT220_TTY=y and CONFIG_SCLP_VT220_CONSOLE is not set:
> 
> ../drivers/s390/char/sclp_vt220.c:771:13: warning: '__sclp_vt220_flush_buffer' defined but not used [-Wunused-function]
>   771 | static void __sclp_vt220_flush_buffer(void)
> 
> so move this function inside the #ifdef block where it is used.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> ---
> Sorry, I can't determine what the Fixes: tag for this should be
> (missing some git fu).

It's not worth spending time to figure this out.

Applied, thanks!