linux-kernel - Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVLbuI6SXVPy2CQm@kroah.com>
Date:   Tue, 28 Sep 2021 11:09:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linuxarm@...wei.com, mauro.chehab@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata

On Tue, Sep 28, 2021 at 08:49:10AM +0100, Lee Jones wrote:
> On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote:
> 
> > On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote:
> > > There are lots of fields in struct hi6421_spmi_pmic that aren't
> > > used. As a matter of fact, only regmap is needed.
> > > 
> > > So, drop the struct as a whole, and just set the regmap as
> > > the drvdata.
> > > 
> > > Acked-by: Mark Brown <broonie@...nel.org>
> > > Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > 
> > As everyone else acked this, any objection for me to just take this in
> > my char-misc tree?
> > 
> > Otherwise, whoever else want to take it:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> If you do end up taking it, you'll have to convert my Ack.
> 
> Although, I'm probably in a better position to take it TBH.
> 
> Happy with either.  You decide.

You can take it, thanks!

greg k-h