[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YVLl4n9O8xXuDeWo@google.com>
Date: Tue, 28 Sep 2021 10:52:34 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc: Chanwoo Choi <cw00.choi@...sung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Liam Girdwood <lgirdwood@...il.com>,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
Krzysztof Kozlowski <krzk@...nel.org>,
Rob Herring <robh@...nel.org>
Subject: Re: [RESEND PATCH v2 4/4] mfd: max14577: Do not enforce (incorrect)
interrupt trigger type
On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 14577/77836 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> The interrupt line is shared between PMIC and charger driver, so using
> level sensitive interrupt is here especially important to avoid races.
> With an edge configuration in case if first PMIC signals interrupt
> followed shortly after by the RTC, the interrupt might not be yet
> cleared/acked thus the second one would not be noticed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Acked-by: Rob Herring <robh@...nel.org>
>
> ---
>
> Changes since v1:
> 1. Add Ack
> ---
> Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++--
> drivers/mfd/max14577.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists