linux-kernel - Re: [Nouveau] [PATCH linux-next] drm/nouveau/nvenc: remove duplicate include in base.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Sep 2021 12:58:41 +0200
From:   Karol Herbst <kherbst@...hat.com>
To:     cgel.zte@...il.com
Cc:     Ben Skeggs <bskeggs@...hat.com>, yong.yiran@....com.cn,
        nouveau <nouveau@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [Nouveau] [PATCH linux-next] drm/nouveau/nvenc: remove duplicate
 include in base.c

Reviewed-by: Karol Herbst <kherbst@...hat.com>

and picked

On Mon, Aug 9, 2021 at 12:14 AM <cgel.zte@...il.com> wrote:
>
> From: yong yiran <yong.yiran@....com.cn>
>
> 'priv.h' included in 'base.c' is duplicated.
> Remove all but the first include of priv.h from base.c.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: yong yiran <yong.yiran@....com.cn>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> index c39e797dc7c9..cf5dcfda7b25 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> @@ -21,7 +21,6 @@
>   */
>  #include "priv.h"
>
> -#include "priv.h"
>  #include <core/firmware.h>
>
>  static void *
> --
> 2.25.1
>