linux-kernel - Re: [PATCH v11] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C8C7AC2D-7A0C-4FCB-8D60-5705D86BC50B@holtmann.org>
Date:   Tue, 28 Sep 2021 13:03:35 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     tjiang@...eaurora.org
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, bgodavar@...eaurora.org,
        c-hbandi@...eaurora.org, hemantg@...eaurora.org, mka@...omium.org,
        rjliao@...eaurora.org, zijuhu@...eaurora.org
Subject: Re: [PATCH v11] Bluetooth: btusb: Add support using different nvm for
  variant WCN6855 controller

Hi Tim,

> the RF performance of wcn6855 soc chip from different foundries will be
> difference, so we should use different nvm to configure them.
> 
> Signed-off-by: Tim Jiang <tjiang@...eaurora.org>
> ---
> drivers/bluetooth/btusb.c | 49 ++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 36 insertions(+), 13 deletions(-)

I am done reviewing this patch and frankly I don’t care how urgent this is for your new chip; and how many times you ping me privately about it. So please find someone else to write and send patches. This is not acceptable behavior here.

If you are blindly ignoring the review comments from Matthias, then I have no idea what to do. This is such a simple patch and it takes 12 revision to get this done.

static void btusb_generate_qca_nvm_name(char *fwname, size_t max_size, const struct qca_version *ver)
{
	u32 rom_version = le32_to_cpu(ver->rom_version);

	if (((ver->flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {
		u16 board_id = le16_to_cpu(ver->board_id);
		const char *variant;

		switch (le32_to_cpu(ver->ram_version)) {
		case WCN6855_2_0_RAM_VERSION_GF:
		case WCN6855_2_1_RAM_VERSION_GF:
			variant = “_gf”;
			break;
		default:
			variant = “”;
			break;
		}

		/* if boardid equal 0, use default nvm without suffix */
		if (board_id == 0x0)
			snprintf(fwname, max_size, "qca/nvm_usb_%08x%s.bin”,
				 rom_version, variant);
		else
			snprintf(fwname, max_size, "qca/nvm_usb_%08x%s_%04x.bin”,
				 rom_version, variant, board_id);
	} else {
		snprintf(fwname, max_size, "qca/nvm_usb_%08x.bin”, rom_version);
	}
}

Regards

Marcel