Message-ID: <e809e7eb-3f38-19fe-46aa-ff40f2fde838@redhat.com>
Date:   Tue, 28 Sep 2021 16:11:49 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Luke Jones <luke@...nes.dev>
Cc:     Bastien Nocera <hadess@...ess.net>, linux-kernel@...r.kernel.org,
        pobrn@...tonmail.com, linux@...ck-us.net,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v11] asus-wmi: Add support for custom fan curves

Hi,

On 9/28/21 2:15 PM, Luke Jones wrote:
> 
> 
> On Tue, Sep 28 2021 at 14:03:54 +0200, Hans de Goede <hdegoede@...hat.com> wrote:
>> Hi,
>>
>> On 9/28/21 1:59 PM, Luke Jones wrote:
>>>
>>>
>>>  On Tue, Sep 28 2021 at 13:56:05 +0200, Hans de Goede <hdegoede@...hat.com> wrote:
>>>>  Hi,
>>>>
>>>>  On 9/28/21 1:43 PM, Luke Jones wrote:
>>>>>   Sure, the path is similar to /sys/devices/platform/asus-nb-wmi/hwmon/hwmon4/pwm1_enable where hwmon4 will likely be different depending on init, and pwm2_enable is the second fan if it exists. The values are 1,2,3 - where 1 = fan curve enabled/manual, 2 = auto. 3 here is custom extra that writes default curve back then defaults to 2.
>>>>>
>>>>>   As I understand it, this should be adhering to the accepted kernel standard, so if you use this for ASUS laptops, then it should carry over to other brands that implement it also.
>>>>
>>>>  Ah, so this is a bit different then how I thought this would work
>>>>  (this is probably better though).
>>>>
>>>>  <snip>
>>>>
>>>>>>>    The fans have settings [1,2,3] under pwm<N>_enable:
>>>>>>>    1. Enable and write settings out
>>>>>>>    2. Disable and use factory fan mode
>>>>>>>    3. Same as 2, additionally restoring default factory curve.
>>>>
>>>>  Quoting Documentation/hwmon/sysfs-interface.rst
>>>>
>>>>  `pwm[1-*]_enable`
>>>>                  Fan speed control method:
>>>>
>>>>                  - 0: no fan speed control (i.e. fan at full speed)
>>>>                  - 1: manual fan speed control enabled (using `pwm[1-*]`)
>>>>                  - 2+: automatic fan speed control enabled
>>>>
>>>>  1 normally means the fans runs at a fixed speed, but you are using it
>>>>  for the custom/manual profile, which is still a temp<->pwm table,
>>>>  right?
>>>>
>>>>  I guess this make sense since full manual control is not supported
>>>>  and this keeps "2" aka auto as being the normal factory auto
>>>>  setting which is good.
>>>>
>>>>  Bastien is this interface usable for p-p-d ?
>>>>
>>>>  I guess that it is a bit annoying that you need to figure out
>>>>  the # in the hwmon# part of the path, but there will be only
>>>>  one hwmon child.
>>>>
>>>>  You could also go through /sys/class/hwmon but then you really
>>>>  have no idea which one to use. Ideally we would have some way
>>>>  to indicate that there is a hmwon class-dev associated with
>>>>  /sys/firmware/acpi/platform_profile but as we mentioned before
>>>>  we should defer coming up with a generic solution for this
>>>>  until we have more then 1 user, so that we hopefully get the
>>>>  generic solution right in one go.
>>>
>>>  If it's at all helpful, I named the interface as "asus_custom_fan_curve". I use this to verify I have the correct hwmon for asusctl. Open to suggestions on that.
>>
>> Ah yes, that means the interface could be looked up through /sys/class/hwmon
>> too, that is probably the safest route to go then, as the
>> /sys/devices/platform/asus-nb-wmi/ path might change if we e.g. ever
>> convert the asus-wmi code to use the new wmi bus interface.
> 
> Oh man... can you link me to relevant bits? I'll stick this on my to-do for future. There will be more patches from me over time so this might be good to have done?

This is not something which we have made mandatory for old code to
switch too. The idea is that you get one wmi_device per guid
under: /sys/bus/wmi/devices/

And then the old platform_drivers (which do typically use
"wmi:GUID" as modalias) are converted to wmi_drivers which
bind to a wmi_device and can make calls on that using e.g. :

wmidev_evaluate_method(wmi_dev, ...)

instead of:

wmi_evaluate_method(GUID, ...)

Grep for module_wmi_driver in drivers/platform/x86
for drivers which have been converted to use this.

I see that the asus code uses 3 GUIDs:

ASUS_WMI_MGMT_GUID
ASUS_NB_WMI_EVENT_GUID
EEEPC_WMI_EVENT_GUID

With the first one being shared and the modalias-es
for the asus-nb-wmi resp eeepc-wmi drivers actually
pointing to the 2 EVENT_GUIDs.

So you could change things to have the 2 drivers
bind to the 2 different event_guids, they can
then also have a notify callback as part of their
driver structure instead of having to call

wmi_install_notify_handler() / wmi_remove_notify_handler()

###

Actually, never mind, switching to the new way of doing things
will move all the sysfs attributes from
/sys/devices/platform/asus-nb-wmi/...
to some thing like:
/sys/devices/platform/PNP0C14:07/wmi_bus/wmi_bus-PNP0C14:07/D931B4CF-F54E-4D07-9420-42858CC6A234

So this would be a clear userspace API break :|

IOW we are stuck with using the old way of doing things
in asus-wmi.

Regards,

Hans







> 
>>
>> Now that you have confirmed that any writes to
>> /sys/firmware/acpi/platform_profile override any custom profiles
>> I wonder if p-p-d needs to take this into account at all though.
>>
>> The easiest way to deal with this in p-p-d, is just to not deal
>> with it at all...    If that turns out to be a bad idea, we
>> can always reconsider and add some special handling to p-p-d for
>> this later.
> 
> I believe Bastiens concern here will be that manual control can still be enabled and ppd won't be aware of it without a check. For example the user may switch profile then re-enable the fan-curve. If some problem arises due to manual control of fan then there is no way for ppd to determine if manual was enabled without actually looking.
> 
> This does mean the pwm name here is set in stone. But also means it's special-cased I guess. Perhaps a check for pwm<N>_enable, then check for the pairs of pwm<N>_auto_<xX> that come with it?
> 
> Ciao,
> Luke.
> 
>>
>> Regards,
>>
>> Hans
>>
> 
> 

Powered by blists - more mailing lists