linux-kernel - Re: [External] Re: Regression in unix stream sockets with the Smack LSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7593b2fb-c8ea-3360-5f44-cee20c6d50e6@schaufler-ca.com>
Date:   Wed, 29 Sep 2021 13:12:26 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     "Jiang Wang ." <jiang.wang@...edance.com>
Cc:     Paul Moore <paul@...l-moore.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Jakub Sitnicki <jakub@...udflare.com>,
        John Fastabend <john.fastabend@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Security Module list 
        <linux-security-module@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Cong Wang <cong.wang@...edance.com>,
        Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [External] Re: Regression in unix stream sockets with the Smack
 LSM

On 9/29/2021 11:36 AM, Jiang Wang . wrote:
> On Wed, Sep 29, 2021 at 8:44 AM Casey Schaufler <casey@...aufler-ca.com> wrote:
>> On 9/20/2021 4:44 PM, Casey Schaufler wrote:
>>> On 9/20/2021 3:35 PM, Jiang Wang . wrote:
>>>> On Wed, Sep 15, 2021 at 9:52 AM Casey Schaufler <casey@...aufler-ca.com> wrote:
>>>>> On 9/13/2021 4:47 PM, Paul Moore wrote:
>>>>>> On Mon, Sep 13, 2021 at 6:53 PM Casey Schaufler <casey@...aufler-ca.com> wrote:
>>>>>>> Commit 77462de14a43f4d98dbd8de0f5743a4e02450b1d
>>>>>>>
>>>>>>>         af_unix: Add read_sock for stream socket types
>>>>>>>
>>>>>>> introduced a regression in UDS socket connections for the Smack LSM.
>>>>>>> I have not tracked done the details of why the change broke the code,
>>>>>>> but this is where bisecting the kernel indicates the problem lies, and
>>>>>>> I have verified that reverting this change repairs the problem.
>>>>>>>
>>>>>>> You can verify the problem with the Smack test suite:
>>>>>>>
>>>>>>>         https://github.com/smack-team/smack-testsuite.git
>>>>>>>
>>>>>>> The failing test is tests/uds-access.sh.
>>>>>>>
>>>> I tried to reproduce with tests/uds-access.sh, but the first two test
>>>> cases always failed.
>> Just piping in that the behavior hasn't changed in 5.15-rc3.
>> It still usually fails, with the occasional success. These
>> tests used to succeed.
>>
> Got it. I am still working on it. I noticed that I did not enable smack
> related kernel configs in my previous tests. I will try again.
> Also, just to make sure, could you send me your kernel config?

I've attached both the fedora and ubuntu configuation files.
Enjoy.


View attachment "smack-fedora.conf" of type "text/plain" (170261 bytes)

View attachment "smack-ubuntu.conf" of type "text/plain" (163096 bytes)