linux-kernel - Re: [PATCH] Partially revert "usb: Kconfig: using select for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVTMUp7UUKUbsKwn@eldamar.lan>
Date:   Wed, 29 Sep 2021 22:28:02 +0200
From:   Salvatore Bonaccorso <carnil@...ian.org>
To:     gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH] Partially revert "usb: Kconfig: using select for
 USB_COMMON dependency"

Hi Greg,

On Tue, Sep 21, 2021 at 04:34:42PM +0200, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> 
> This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> USB_LED_TRIG.  This config symbol has bool type and enables extra code
> in usb_common itself, not a separate driver.  Enabling it should not
> force usb_common to be built-in!
> 
> Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Salvatore Bonaccorso <carnil@...ian.org>
> ---
>  drivers/usb/common/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
> index 5e8a04e3dd3c..b856622431a7 100644
> --- a/drivers/usb/common/Kconfig
> +++ b/drivers/usb/common/Kconfig
> @@ -6,8 +6,7 @@ config USB_COMMON
>  
>  config USB_LED_TRIG
>  	bool "USB LED Triggers"
> -	depends on LEDS_CLASS && LEDS_TRIGGERS
> -	select USB_COMMON
> +	depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
>  	help
>  	  This option adds LED triggers for USB host and/or gadget activity.

Sorry for bothering you again. Is this patch now ok, or do you need me
to change something else? Or do I miss something?

Regards,
Salvatore