linux-kernel - Re: [PATCH 1/3] scsi: qla1280: Fix a function name in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1v92kf5pj.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 28 Sep 2021 23:12:43 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Adam Radford <aradford@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        Michael Reed <mdr@....com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] scsi: qla1280: Fix a function name in comments

Cai,

> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.

pci_map_single() was the appropriate interface when the change log entry
was written. And the original entry accurately describes the change that
was made to the code back then. Whereas your proposed fix does not.

There is little benefit to having change logs in drivers in a modern
context. However, these entries predate git history and should therefore
be preserved.

-- 
Martin K. Petersen	Oracle Linux Engineering