linux-kernel - RE: [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00f901d7b4e0$581ae2f0$0850a8d0$@samsung.com>
Date:   Wed, 29 Sep 2021 08:46:04 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Bao D. Nguyen'" <nguyenb@...eaurora.org>, <cang@...eaurora.org>,
        <asutoshd@...eaurora.org>, <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>
Cc:     <linux-arm-msm@...r.kernel.org>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>,
        "'Avri Altman'" <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'open list'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during
 clock scaling

Hello,

>-----Original Message-----
>From: nguyenb=codeaurora.org@...codeaurora.org
>[mailto:nguyenb=codeaurora.org@...codeaurora.org] On Behalf Of Bao D.
>Nguyen
>Sent: Tuesday, September 28, 2021 2:36 PM
>To: cang@...eaurora.org; asutoshd@...eaurora.org;
>martin.petersen@...cle.com; linux-scsi@...r.kernel.org
>Cc: linux-arm-msm@...r.kernel.org; Bao D . Nguyen
><nguyenb@...eaurora.org>; Andy Gross <agross@...nel.org>; Bjorn Andersson
><bjorn.andersson@...aro.org>; Alim Akhtar <alim.akhtar@...sung.com>; Avri
>Altman <avri.altman@....com>; James E.J. Bottomley <jejb@...ux.ibm.com>;
>open list <linux-kernel@...r.kernel.org>
>Subject: [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock
scaling
>
>From: Asutosh Das <asutoshd@...eaurora.org>
>
>Qualcomm controller needs to be in hibern8 before scaling clocks.
>This change puts the controller in hibern8 state before scaling and brings
it out
>after scaling of clocks.
>
>Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
>Signed-off-by: Bao D. Nguyen <nguyenb@...eaurora.org>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> drivers/scsi/ufs/ufs-qcom.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index
>92d4c61..92f5bb4 100644
>--- a/drivers/scsi/ufs/ufs-qcom.c
>+++ b/drivers/scsi/ufs/ufs-qcom.c
>@@ -1212,24 +1212,34 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba
>*hba,
> 	int err = 0;
>
> 	if (status == PRE_CHANGE) {
>+		err = ufshcd_uic_hibern8_enter(hba);
>+		if (err)
>+			return err;
> 		if (scale_up)
> 			err = ufs_qcom_clk_scale_up_pre_change(hba);
> 		else
> 			err = ufs_qcom_clk_scale_down_pre_change(hba);
>+		if (err)
>+			ufshcd_uic_hibern8_exit(hba);
>+
> 	} else {
> 		if (scale_up)
> 			err = ufs_qcom_clk_scale_up_post_change(hba);
> 		else
> 			err = ufs_qcom_clk_scale_down_post_change(hba);
>
>-		if (err || !dev_req_params)
>+
>+		if (err || !dev_req_params) {
>+			ufshcd_uic_hibern8_exit(hba);
> 			goto out;
>+		}
>
> 		ufs_qcom_cfg_timers(hba,
> 				    dev_req_params->gear_rx,
> 				    dev_req_params->pwr_rx,
> 				    dev_req_params->hs_rate,
> 				    false);
>+		ufshcd_uic_hibern8_exit(hba);
> 	}
>
> out:
>--
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a
>Linux Foundation Collaborative Project