linux-kernel - Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Sep 2021 20:54:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Wu Zongyong <wuzongyong@...ux.alibaba.com>, jasowang@...hat.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, mst@...hat.com
Cc:     kbuild-all@...ts.01.org, wei.yang1@...ux.alibaba.com
Subject: Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

Hi Wu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wu-Zongyong/virtio-pci-introduce-legacy-device-module/20210929-115033
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a4e6f95a891ac08bd09d62e3e6dae239b150f4c1
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/86ed35603fb93a4bc8c8929ff89edd5f6556ca44
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wu-Zongyong/virtio-pci-introduce-legacy-device-module/20210929-115033
        git checkout 86ed35603fb93a4bc8c8929ff89edd5f6556ca44
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/vdpa/alibaba/eni_vdpa.c:446:13: error: 'eni_vdpa_free_irq_vectors' defined but not used [-Werror=unused-function]
     446 | static void eni_vdpa_free_irq_vectors(void *data)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vdpa/alibaba/eni_vdpa.c:423:12: error: 'eni_vdpa_get_num_queues' defined but not used [-Werror=unused-function]
     423 | static u16 eni_vdpa_get_num_queues(struct eni_vdpa *eni_vdpa)
         |            ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vdpa/alibaba/eni_vdpa.c:396:37: error: 'eni_vdpa_ops' defined but not used [-Werror=unused-const-variable=]
     396 | static const struct vdpa_config_ops eni_vdpa_ops = {
         |                                     ^~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/eni_vdpa_free_irq_vectors +446 drivers/vdpa/alibaba/eni_vdpa.c

   395	
 > 396	static const struct vdpa_config_ops eni_vdpa_ops = {
   397		.get_features	= eni_vdpa_get_features,
   398		.set_features	= eni_vdpa_set_features,
   399		.get_status	= eni_vdpa_get_status,
   400		.set_status	= eni_vdpa_set_status,
   401		.reset		= eni_vdpa_reset,
   402		.get_vq_num_max	= eni_vdpa_get_vq_num_max,
   403		.get_vq_num_min	= eni_vdpa_get_vq_num_min,
   404		.get_vq_state	= eni_vdpa_get_vq_state,
   405		.set_vq_state	= eni_vdpa_set_vq_state,
   406		.set_vq_cb	= eni_vdpa_set_vq_cb,
   407		.set_vq_ready	= eni_vdpa_set_vq_ready,
   408		.get_vq_ready	= eni_vdpa_get_vq_ready,
   409		.set_vq_num	= eni_vdpa_set_vq_num,
   410		.set_vq_address	= eni_vdpa_set_vq_address,
   411		.kick_vq	= eni_vdpa_kick_vq,
   412		.get_device_id	= eni_vdpa_get_device_id,
   413		.get_vendor_id	= eni_vdpa_get_vendor_id,
   414		.get_vq_align	= eni_vdpa_get_vq_align,
   415		.get_config_size = eni_vdpa_get_config_size,
   416		.get_config	= eni_vdpa_get_config,
   417		.set_config	= eni_vdpa_set_config,
   418		.set_config_cb  = eni_vdpa_set_config_cb,
   419		.get_vq_irq	= eni_vdpa_get_vq_irq,
   420	};
   421	
   422	
 > 423	static u16 eni_vdpa_get_num_queues(struct eni_vdpa *eni_vdpa)
   424	{
   425		struct virtio_pci_legacy_device *ldev = &eni_vdpa->ldev;
   426		u32 features = vp_legacy_get_features(ldev);
   427		u16 num = 2;
   428	
   429		if (features & BIT_ULL(VIRTIO_NET_F_MQ)) {
   430			__virtio16 max_virtqueue_pairs;
   431	
   432			eni_vdpa_get_config(&eni_vdpa->vdpa,
   433				offsetof(struct virtio_net_config, max_virtqueue_pairs),
   434				&max_virtqueue_pairs,
   435				sizeof(max_virtqueue_pairs));
   436			num = 2 * __virtio16_to_cpu(virtio_legacy_is_little_endian(),
   437					max_virtqueue_pairs);
   438		}
   439	
   440		if (features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ))
   441			num += 1;
   442	
   443		return num;
   444	}
   445	
 > 446	static void eni_vdpa_free_irq_vectors(void *data)
   447	{
   448		pci_free_irq_vectors(data);
   449	}
   450	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (68952 bytes)