linux-kernel - Re: [PATCH 1/4] dt-bindings: devicetree documentation for secure domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18d78005-828c-eea3-2b6f-8bf6333a6963@linaro.org>
Date:   Wed, 29 Sep 2021 15:06:28 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Jeya R <jeyr@...eaurora.org>, linux-arm-msm@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        fastrpc.upstream@....qualcomm.com
Subject: Re: [PATCH 1/4] dt-bindings: devicetree documentation for secure
 domain

Thanks Jeya,


Subject line should look something like "misc: dt-bindings: fastrpc..."


On 24/09/2021 13:19, Jeya R wrote:
> Add information about secure domain property.
> 
> Signed-off-by: Jeya R <jeyr@...eaurora.org>
> ---
>   Documentation/devicetree/bindings/misc/qcom,fastrpc.txt | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> index 2a1827a..276c1d1 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> @@ -49,6 +49,12 @@ on the dsp.
>   		    context bank. Defaults to 1 when this property
>   		    is not specified.
>   
> +- secure-domains:

Should this not be qcom,secure-domain ??

You have added this binding for compute banks but the driver changes 
suggest that it should be for fastrpc.



> +	Usage: Optional
> +	Value type: <empty>

boolean?

> +	Definition: Specify DSP domain is secure, must be
> +		    "qcom,secure-domain"
May be reword this to "Only applicable for CDSP domains, presence of 
this property indicates that domain in secured"



> +
>   Example:
>   
>   adsp-pil {
>