linux-kernel - Re: [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVSHmu0Wtin/2pXN@grain>
Date:   Wed, 29 Sep 2021 18:34:50 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kbuild-all@...ts.01.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Andrey Vagin <avagin@...il.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx

On Wed, Sep 29, 2021 at 11:20:23PM +0800, kernel test robot wrote:
...
> sparse warnings: (new ones prefixed by >>)
> >> kernel/sys.c:1997:58: sparse: sparse: incorrect type in argument 3 (different address spaces) @@     expected void const [noderef] __user *addr @@     got unsigned long long [usertype] *[addressable] auxv @@
>    kernel/sys.c:1997:58: sparse:     expected void const [noderef] __user *addr
>    kernel/sys.c:1997:58: sparse:     got unsigned long long [usertype] *[addressable] auxv
>    kernel/sys.c:1068:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct task_struct *p1 @@     got struct task_struct [noderef] __rcu *real_parent @@
>    kernel/sys.c:1068:32: sparse:     expected struct task_struct *p1
>    kernel/sys.c:1068:32: sparse:     got struct task_struct [noderef] __rcu *real_parent
>    kernel/sys.c: note: in included file (through include/linux/rcuwait.h, include/linux/percpu-rwsem.h, include/linux/fs.h, ...):
>    include/linux/sched/signal.h:710:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
>    include/linux/sched/signal.h:710:37: sparse:     expected struct spinlock [usertype] *lock
>    include/linux/sched/signal.h:710:37: sparse:     got struct spinlock [noderef] __rcu *
> 
> vim +1997 kernel/sys.c

Thanks for report! I happen to miss Dima's reply in first place as well :(
I'll take a look on this patch. The issie itself is implicit type conversion,
shouldn't be a bug in general but need to address as well. Will do.