linux-kernel - Re: [PATCH -next] intel: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Sep 2021 16:12:19 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "yang.lee@...ux.alibaba.com" <yang.lee@...ux.alibaba.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] intel: Simplify bool conversion

On Wed, 2021-09-29 at 14:56 +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/i40e/i40e_xsk.c:229:35-40: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/intel/ice/ice_xsk.c:399:35-40: WARNING:
> conversion to bool not needed here
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Tony Nguyen <anthony.l.nguyen@...el.com>

This applies to patches that went through BPF[1] and aren't on the
Intel wired LAN yet. BPF - did you want to pick this up?

[1]
https://patchwork.kernel.org/project/netdevbpf/list/?series=550775&stat
e=*

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 6f85879..ea06e95 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -226,7 +226,7 @@ bool i40e_alloc_rx_buffers_zc(struct i40e_ring
> *rx_ring, u16 count)
>  	rx_desc->wb.qword1.status_error_len = 0;
>  	i40e_release_rx_desc(rx_ring, ntu);
>  
> -	return count == nb_buffs ? true : false;
> +	return count == nb_buffs;
>  }
>  
>  /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c
> b/drivers/net/ethernet/intel/ice/ice_xsk.c
> index 7682eaa..35b6e81 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.c
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
> @@ -396,7 +396,7 @@ bool ice_alloc_rx_bufs_zc(struct ice_ring
> *rx_ring, u16 count)
>  	rx_desc->wb.status_error0 = 0;
>  	ice_release_rx_desc(rx_ring, ntu);
>  
> -	return count == nb_buffs ? true : false;
> +	return count == nb_buffs;
>  }
>  
>  /**