linux-kernel - Re: [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1584373E-34C9-4B0E-9E84-6C29F919EE38@fb.com>
Date:   Wed, 29 Sep 2021 16:56:17 +0000
From:   Nick Terrell <terrelln@...com>
To:     David Sterba <dsterba@...e.cz>
CC:     "B093B859-53CC-4818-8CC3-A317F4872AD6@...com" 
        <B093B859-53CC-4818-8CC3-A317F4872AD6@...com>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10



> On Sep 29, 2021, at 3:06 AM, David Sterba <dsterba@...e.cz> wrote:
> 
> On Wed, Sep 29, 2021 at 01:30:26AM +0000, Nick Terrell wrote:
>>> On Sep 28, 2021, at 5:22 PM, Tom Seewald <tseewald@...il.com> wrote:
>>> Has this been abandoned or will there be future attempts at syncing the
>>> in-kernel zstd with the upstream project?
>> 
>> Sorry for the lack of action, but this has not been abandoned. I’ve just been
>> preparing a rebased patch-set last week, so expect to see some action soon.
>> Since we’re not in a merge window, I’m unsure if it is best to send out the
>> updated patches now, or wait until the merge window is open, but I’m about to
>> pose that question to the LKML.
> 
> If you send it once merge window is open it's unlikely to be merged. The
> code must be ready before it opens and part of linux-next for a week at
> least if not more.
> 
>> This work has been on my back burner, because I’ve been busy with work on
>> Zstd and other projects, and have had a hard time justifying to myself spending
>> too much time on this, since progress has been so slow.
> 
> What needs to be done from my POV:
> 
> - refresh the patches on top of current mainline, eg. v5.15-rc3
> 
> - make sure it compiles and works with current in-kernel users of zstd,
>  ie. with btrfs in particular, I can do some tests too
> 
> - push the patches to a public branch eg. on k.org or github
> 
> - ask for adding the branch to linux-next
> 
> - try to get some feedback from people that were objecting in the past,
>  and of course gather acks or supportive feedback
> 
> - once merge window opens, send a pull request to Linus, write the
>  rationale why we want this change and summarize the evolution of the
>  patchset and why the full version update is perhaps the way forward

Thanks for the clear explanation, that was very helpful! I’ve already rebased
and re-tested myself. I’ll send out a request asking it to be added to linux-next,
and try to gather feedback/acks on that thread. I’ll prepare the rationale for the
linux-next request, so you all can get a chance to read it.

Thanks,
Nick