linux-kernel - Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5465ad4d-8999-ad3d-8858-c2e1b8b463f8@infradead.org>
Date:   Thu, 30 Sep 2021 11:45:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Aditya Srivastava <yashsri421@...il.com>
Subject: Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc

On 9/30/21 10:01 AM, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Sep 28, 2021 at 12:52:03PM -0700, Randy Dunlap wrote:
>> On 9/28/21 11:57 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> Fix build warnings from the kernel test robot:
>>>>
>>>> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>>>>       * Block until pending data transfers have completed.
>>>>
>>>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>>>> Reported-by: kernel test robot <lkp@...el.com>
>>>> Cc: Sebastian Reichel <sre@...nel.org>
>>>> Cc: Aditya Srivastava <yashsri421@...il.com>
>>>> Acked-by: Pavel Machek <pavel@....cz>
>>>
>>> If noone applies it, you may want to send it to akpm, he's  often
>>> helpful in pushing similar patches.
>>
>> Yes, good idea. Thanks.
> 
> Looks like I missed v1. The patch LGTM and I can apply it to the hsi tree.
> If you already sent it to akpm, that's also fine. Not much is happening in
> HSI nowadays and it probably will be the only patch for the next cycle.

You go ahead with it, please.

thanks.
-- 
~Randy